Hi Ian, I don't know, but the code change I'm seeing in JDBCDataStore is not where I expected it... maybe it bears some relation. The check on whether a visitor can be optimized out or not is normally made at the beginning of this method: https://github.com/geotools/geotools/blob/7c49932f89472db7bfd76b42b137c5392f1661c2/modules/library/jdbc/src/main/java/org/geotools/jdbc/JDBCDataStore.java#L1395
You check your condition, and return null right away if it's not a match. So I'd check there if the filter is fully supported, or not (the splitter is a way, although there is also IsFullySupportedFilterVisitor... but it's not commonly used, unlike the splitter one). That said, the check you're proposing is way more nested, other stuff already happened, and it's throwing an exception ... maybe in some databases that leaves a dirty state somewhere? Cheers Andrea On Sat, Jun 11, 2022 at 3:10 PM Ian Turton <ijtur...@gmail.com> wrote: > While experimenting with function handling in JDBC datastores I added a > new test as a just in case test - it should already pass on all databases. > I was just checking strMatches functions didn't get passed to the database > and all seemed fine with H2 and Postgis locally, when I pushed it to gtihub > I get failures from Oracle and Infomix. > > The test is > https://github.com/ianturton/geotools/blob/6693a5ec64aee6766821c6b8a8e9d29adccfc7c1/modules/library/jdbc/src/test/java/org/geotools/jdbc/JDBCFeatureSourceOnlineTest.java#L755 > which (I think) is functionally the same as > https://github.com/ianturton/geotools/blob/6693a5ec64aee6766821c6b8a8e9d29adccfc7c1/modules/library/jdbc/src/test/java/org/geotools/jdbc/JDBCFeatureSourceOnlineTest.java#L739 > which does pass. > > The failed CI runs are at > https://github.com/geotools/geotools/runs/6842365526?check_suite_focus=true > and > https://github.com/geotools/geotools/runs/6842365461?check_suite_focus=true > > Can anyone think why two databases are failing but the rest are fine? > > cheers > > Ian > > -- > Ian Turton > _______________________________________________ > GeoTools-Devel mailing list > GeoTools-Devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- Regards, Andrea Aime == GeoServer Professional Services from the experts! Visit http://bit.ly/gs-services-us for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions Group phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 333 8128928 https://www.geosolutionsgroup.com/ http://twitter.com/geosolutions_it ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati “GDPR”), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 “GDPR” - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
