Hi Andrea, Thanks for your reply. Your proposal sounds good to me. I'll open a Jira item and prepare a pull request.
Cheers, Stefan From: Andrea Aime <andrea.a...@geosolutionsgroup.com> Sent: Tuesday, December 27, 2022 11:52 AM To: Uhrig, Stefan <stefan.uh...@sap.com> Cc: Jody Garnett <jody.garn...@gmail.com>; GeoTools <geotools-devel@lists.sourceforge.net> Subject: Re: [Geotools-devel] JDBCDataStore blocks search hints on virtual tables On Wed, Dec 14, 2022 at 2:45 PM Uhrig, Stefan <stefan.uh...@sap.com<mailto:stefan.uh...@sap.com>> wrote: If you don't have objections, I'd like to add a way to let the SQLDialect decide. However, I'm not sure what the best way would be. I considered the following options: 1. Ask the SQLDialect via a method whether hints should be added, e.g. boolean handleSelectHintsOnVirtualTableQueries() returning false by default. 2. Add a new method to add "general" hints independent of the query type, e.g. handleGeneralHints(SimpleFeatureType featureType, Query query, StringBuffer sql), doing nothing by default. 3. Pass along the information on the type of query to handleSelectHints(). That would be an incompatible change though. Maybe overloading the method would be an option. Yup, I'm all for letting the dialect decide. Maybe a shorter method name would help (we're using 4 chars indents and 100 columns, need to try and be short and to the point). What about "boolean applyHintsOnVirtualTables()", defaulting to false? Cheers Andrea == GeoServer Professional Services from the experts! Visit http://bit.ly/gs-services-us<https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fbit.ly%2Fgs-services-us&data=05%7C01%7Cstefan.uhrig%40sap.com%7C240fcecb30c64bb630e008dae7f87684%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C638077351574610055%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=s9T%2FhdxYNOYBiVbeGCWWppQpVrKOzZIovf%2BNCTxJREQ%3D&reserved=0> for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions Group phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 https://www.geosolutionsgroup.com/<https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.geosolutionsgroup.com%2F&data=05%7C01%7Cstefan.uhrig%40sap.com%7C240fcecb30c64bb630e008dae7f87684%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C638077351574610055%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=oHusSxypU4GGO8anTMUmbG9%2FWVDPDl8%2BJUJYpbVAIZE%3D&reserved=0> http://twitter.com/geosolutions_it<https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitter.com%2Fgeosolutions_it&data=05%7C01%7Cstefan.uhrig%40sap.com%7C240fcecb30c64bb630e008dae7f87684%7C42f7676cf455423c82f6dc2d99791af7%7C0%7C0%7C638077351574766778%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=eWHuHyaD7aKWTETEMaoS93oLhawcQKk4zDErrpPtKIo%3D&reserved=0> ------------------------------------------------------- Con riferimento alla normativa sul trattamento dei dati personali (Reg. UE 2016/679 - Regolamento generale sulla protezione dei dati "GDPR"), si precisa che ogni circostanza inerente alla presente email (il suo contenuto, gli eventuali allegati, etc.) è un dato la cui conoscenza è riservata al/i solo/i destinatario/i indicati dallo scrivente. Se il messaggio Le è giunto per errore, è tenuta/o a cancellarlo, ogni altra operazione è illecita. Le sarei comunque grato se potesse darmene notizia. This email is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. We remind that - as provided by European Regulation 2016/679 "GDPR" - copying, dissemination or use of this e-mail or the information herein by anyone other than the intended recipient is prohibited. If you have received this email by mistake, please notify us immediately by telephone or e-mail
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
