On Mon, 8 May 2023 at 13:46, Cécile Vuilleumier < cecile.vuilleum...@camptocamp.com> wrote:
> Hello all, > > This is a follow-up to: > https://sourceforge.net/p/geoserver/mailman/geoserver-users/thread/9c182de7-da6d-7ba8-0689-a4ecd29e3381%40camptocamp.com/#msg37788010 > The issue was initially reported to us by a customer for rotated markers > (ESRI font) with margins. For non-rotated symbols (as in my initial > message), it seems the problem is visible only for certain resolutions (for > me: when working with a very large screen, or by adding the parameter > "&FORMAT_OPTIONS=dpi:96" to the GetMap request). > > After locally debugging the code, it appears that the margin between > symbols is not taken into account when creating the 3x3 grid and when > clipping the subimage from it (that is, the central symbol that will be > used for tiling). The margin is added afterwards (outside the > markToTilableImage() function) thus resulting in broken up symbols. > > I have a branch which addresses the issue and hopefully does not introduce > any regression (the unit tests are passing and I also did some manual > testing): > > https://github.com/vuilleumierc/geotools/commit/e9af35eeaf5984e7f6b6514c5f9c03a6846e5aaa > > I am also attaching two images (actual result and result with proposed > solution) and the corresponding SLD file. > Would you consider a PR for this, and if yes do we need a JIRA ticket to > open one? If more info is needed, let me know. > > That looks great, please open a ticket and then push the PR with a reference to the ticket. Thanks Ian
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
