Great, yes the change would be in the method doing the actual download
(https://github.com/geotools/geotools/blob/main/modules/library/xml/src/main/java/org/geotools/xml/resolver/SchemaCache.java#L235)
and the XML caching mechanism would not / should not be impacted.
I will work on a PR but further feedback is of course welcome
On 5/31/24 4:41 PM, Jody Garnett wrote:
That is … amazing you can get in there and make the change. Wow.
For normal XML parsing does it use the cache?
--
Jody Garnett
On Fri, May 31, 2024 at 2:22 AM Cécile Vuilleumier
<cecile.vuilleum...@camptocamp.com> wrote:
Hi all
This is a follow-up to:
https://osgeo-org.atlassian.net/browse/GEOT-7576 (Make SchemaCache
use the HttpClient from the GeoTools hints)
The goal would be to be able to configure an HTTP proxy for XML
schema requests using the GeoTools hint HTTP_CLIENT_FACTORY
(similarly to OWS requests). If not set the fallback would be the
SimpleHttpClient.
I have been looking at the code and it seems doable, although the
SchemaCache does something special in order to follow HTTP
redirections. An option could be to move this to the
SimpleHttpClient GET method or to overload this method.
(Note that after testing it seems HttpURLConnection does already
follow redirects but only if they have the same protocol e.g. HTTP
or HTTPS)
Would you be in favor of this change? Any comments about the
implementation?
Thanks in advance, Cécile
--
*camptocamp*
*Cécile Vuilleumier
*
Geospatial developer
www.camptocamp.com <http://www.camptocamp.com>
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
