Shaun, I've created the issue for you: <http://jira.codehaus.org/browse/GEOT-3248> Feel free to log in and add yourself as a watcher to the issue to be notified of changes.
Cheers, Gabriel On Aug 17, 2010, at 12:20 AM, Gabriel Roldan wrote: > Hi Shaun, > > I've been digging into the code, and though the result is functionally > correct (the returning feature type contains only the required property), > internally the geometry column is being fetched even if it doesn't need to. > So it's a bug. > > You're right the culprit is the use of FilterAttributeExtractor. It should be > used, but only if after splitting the geotools filter into backend's > supported and unsupported filters lead to an unsupported filter that needs to > be checked at runtime. > > Performance wise, FeatureCollection and FeatureReader should perform the same > as FeatureCollection is just a thin wrapper around a FeatureSource + Query, > and returns another adapter at the features() method that adapts > FeatureReader to FeatureIterator. > > Could you please create a JIRA issue for this, just describe what you sent on > your original email, assign it the data-arcsde component and assign it to me? > This way you'll be automatically notified about comments/progress and when > the issue is fixed (which I hope to do asap). Jira is here: > <http://jira.codehaus.org/browse/GEOT> > > Best regards, > Gabriel > > > On Aug 16, 2010, at 11:37 PM, Shaun Forbes wrote: > >> Quick follow-up, >> >> Looks like property_view is a table not a view, turns out that "_view" means >> that it's a layer, attribute data is in a separate "table". >> >> Also, on the performance of FeatureCollection vs. FeatureReader, it looks >> like the comparison wasn't necessarily fair, since the FeatureReader was >> returning only a particular column, the 'key' that we're trying to return, >> whereas the FeatureCollection test was returning everything, and it wasn't >> using the same code path as the initial problem I asked for help on, so that >> may be a red herring. >> Looks like I will need to have a closer look at the difference between the >> two to see if the FeatureCollection is returning the geometry like the >> FeatureReader option. Actually I guess it will be, since it's just returning >> everything, maybe it's doing lazy initialization of the geometry that isn't >> happening on the FeatureReader side. >> >> Cheers, >> Shaun >> ------------------------------------------------------------------------------ >> This SF.net email is sponsored by >> >> Make an app they can't live without >> Enter the BlackBerry Developer Challenge >> http://p.sf.net/sfu/RIM-dev2dev >> _______________________________________________ >> Geotools-gt2-users mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/geotools-gt2-users > ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Geotools-gt2-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-gt2-users
