On 09/21/2010 12:03 PM, Andrea Aime wrote:
On 21/09/2010 20:48, Dustin Parker wrote:Hey all,We're using JNDI datastores in GeoServer and GeoTools occassionally logs: There's code using JDBC based datastore and not disposing them... I believe this is due to the interaction between JDBCDataStore.finalize() and JDBCDataStore.dispose(); the latter will check if the data source is a ManageableDataSource. If it's not managable by GT, no state will change even if dispose() is called. However, finalize() doesn't make the same check before logging. Either GeoServer should wrap JNDI data sources with a NOP close() or GT needs to check before logging this warning (or have dispose() set dataSource = null unconditionally). What do you think?The latter would be better. Care to cook up a patch and attach it to a improvement request on jira.codehaus.org? Cheers Andrea
Sure, no problem. -- Dustin Parker - Forward Slope, Inc. Cell: 619 277 2591
smime.p7s
Description: S/MIME Cryptographic Signature
------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________ Geotools-gt2-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-gt2-users
