Hi Sergey,
Then we can change pixelWidth to 0
in gerbv_render_layer_to_cairo_target_without_transforming() when
pixelOutput is FALSE.
As gerbv_draw_amacro() doesn't have pixelOutput, I think pixelWidth should
have this information.
2017年2月15日(水) 15:56 Sergey Alyoshin <alyoshi...@gmail.com>:
> On Tue, Feb 14, 2017 at 5:03 PM, Koki Nomura <nom...@agic.cc> wrote:
> > Hi,
> >
> > Exporting PDF or SVG files contains unnecessary shift of coordinates in
> > vector export. The pattern is displayed correctly in the viewer.
> >
> > I attached a simple Gerber file to reproduce this bug in bug report #207
> > (https://sourceforge.net/p/gerbv/bugs/207/).
> >
> > I'm very sure that this bug is caused by the statement below in
> src/draw.c.
> >
> > if (halfWidth < pixelWidth)
> > halfWidth = pixelWidth;
> >
> > This doesn't make sense when exporting vector files, so I've commented
> out
> > here and my patch has worked fine for me. (I don't need to export image
> > files.)
>
> Yes, confirming.
>
>
> > A quick fix which came to mind first is to pass a flag to show if
> exporting
> > vector or image to gerbv_draw_amacro function. This flag can be passed by
> > gerbv_render_all_layers_to_cairo_target_for_vector_output.
>
> gerbv_draw_amacro() is a library function, so it is not good to change
> its arguments.
>
>
> > Let me know your opinions. I'm willing to write and post a patch if
> needed.
>
> My opinion is: we should try to fix this without adding function argument.
>
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> Gerbv-devel mailing list
> Gerbv-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gerbv-devel
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Gerbv-devel mailing list
Gerbv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gerbv-devel
