Just a general comment...
I would like to see that we never lose exception detail. As it makes debugging problems very, very difficult.
--jason
On Saturday, August 16, 2003, at 09:54 AM, Jeremy Boynes wrote:
Got lost in the noise...
One thing, I am curious about this fragment: try { manager = factory.getDeploymentManager(uri, username, password); if (manager != null) { return manager; } } catch (DeploymentManagerCreationException e) { throw new DeploymentManagerCreationException("Could not get DeploymentManager: " + e.getMessage()); }
Why are you rethrowing the same exception with a munged message?
Given we need to do that, can we inject the original cause: DeploymentManagerCreationException e2 = new new DeploymentManagerCreationException("Could not get DeploymentManager: " + e.getMessage()); e2.initCause(e); throw e2;
-----Original Message----- From: Aaron Mulder [mailto:[EMAIL PROTECTED] Sent: Friday, August 15, 2003 8:47 PM To: [EMAIL PROTECTED] Subject: [PATCH] JSR-88 DFM Revisions, Take Two
Is there a reason why the 7:15 PM patch was applied before the 3
PM patch? Anyway, here's another copy of the earlier one, against the
current source. Again, the MockDeployment* classes should be removed when
applying these two changes.
Aaron
