On Monday, Aug 25, 2003, at 14:57 Europe/London, Cabrera, Alan wrote:

-----Original Message-----
From: Alex Blewitt [mailto:[EMAIL PROTECTED]

throw new
I18NException("info.org.apache.geronimo.mail-authentication.failed")

That way, it's easier to 'guess' what the message is than a number,
which can be mistyped or may not mean anything.

I partially agree w/ this but don't see the point in including the
"org.apache.geronimo". After all, the messages are for geronimo; this is an
obvious implicit understanding. Why overstate it to provide long, unweldy,
keys?

True. Possibly not worth putting in, but it does leave the question as to what happens with things in the specs/ folder (such as javax.mail.Store). I originally thought about putting in the o.a.g and jx.m prefixes so that you'd know which FQN class it'd come from.


But I concur with your observation. Perhaps it would be better to shorten it, and use the module name instead? In which case, we could use a charater (say, S or M) to indicate spec or module; and/or put a prefix on the front:

throw new I18NException("mail.authentication-failed");

or

throw new I18NException("Smail.authentication-failed");
throw new I18NException("Mmail.authentication-failed");

or

throw new I18NException("spec.mail.authentication-failed");
throw new I18NException("module.mail.authentication-failed");

Alex.



Reply via email to