Message: A new issue has been created in JIRA.
--------------------------------------------------------------------- View the issue: http://jira.codehaus.org/secure/ViewIssue.jspa?key=GERONIMO-95 Here is an overview of the issue: --------------------------------------------------------------------- Key: GERONIMO-95 Summary: [PATCH] DeploymentPlan may not query all tasks in canRun() Type: Bug Status: Unassigned Priority: Minor Time Spent: Unknown Remaining: Unknown Project: Apache Geronimo Components: core Assignee: Reporter: Gareth Bryan Created: Sun, 28 Sep 2003 9:51 AM Updated: Sun, 28 Sep 2003 9:51 AM Description: In o.a.g.kernel.deployment.DeploymentPlan.canRun(), incorrect usage of the short-circuit AND operator means that if a previous task reported that it could not run, subsequent tasks will not be queried. This is the opposite to the indened behaviour which is documented in the code comment "always check each task, so the task can throw an exception if the task can never run". The patch file is a trivial change from: canRun = canRun && task.canRun() to: canRun = task.canRun() && canRun The patch was generated by running "cvs diff -uN" from the project root directory (incubator-geronimo). Also included in the patch and attached zip file is the testcase which brought this problem to light. --------------------------------------------------------------------- JIRA INFORMATION: This message is automatically generated by JIRA. If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira
