> From: David Jencks [mailto:[EMAIL PROTECTED]
>
> On Sunday, January 4, 2004, at 01:22 PM, Jacek Laskowski wrote:
>
> > Alan D. Cabrera wrote:
> >> Did this get resolved?
> >
> > Anyway, it's not been checked in the change to the main maven.xml,
> > i.e. setting javax.security.jacc.PolicyConfigurationFactory.provider
> > to org.apache.geronimo.security.GeronimoPolicyConfigurationFactory.
>
> I thought probably this should be set in code rather than before
> geronimo starts, but I wasn't sure where. It looks like Alan agrees
> with me, from his other message.
Yes. I think that it's best to have all the security related
configurations inside the security service file.
> > I don't see why it was not added. Unless I'm mistaken the property
> > must be set in order to deploy EJBs (and perhaps war and other
modules
> > with security settings). I guess, David probably overlooked it by
> > mistake.
You'll see that I set it in my unit tests.
> > Also, it's been necessary to have parameterless constructors of the
> > *ModuleConfiguration as otherwise they weren't called at all (with
> > some bizarre error messages). I see the change was not applied so
that
> > EJBModuleConfiguration doesn't contain something as follows:
> >
> > public EJBModuleConfiguration() {
> > super(null);
> > }
> >
> > I think WebModuleConfiguration needs the same thing.
>
> This doesn't make sense to me yet. Why is this needed? Did I miss a
> failing test? The EJBModuleDeploymentPlanner sets up the task to use
> the non-default constructor, which is the only one that makes sense to
> me.
I agree w/ David. I don't think that this is needed.
> > Also, don't see the check whether or not excludeList variable is
null.
> > According to modules/core/src/schema/geronimo-ejb-jar.xsd
cardinality
> > of <exclude-list> element is 0 and more. @see
> > modules/core/src/java/org/apache/geronimo/security/util/
> > ConfigurationUtil.java.
Fixed. Thanks!
Regards,
Alan
