> -----Original Message----- > From: Jacek Laskowski [mailto:[EMAIL PROTECTED] > > [EMAIL PROTECTED] wrote: > > > djencks 2003/12/28 12:13:06 > > > > Modified: modules/core/src/java/org/apache/geronimo/security > > EJBModuleConfiguration.java SecurityRealm.java > > SecurityService.java WebModuleConfiguration.java > > Log: > > Introduce some constants for strings > > > > Revision Changes Path > > 1.4 +3 -1 incubator- > geronimo/modules/core/src/java/org/apache/geronimo/security/EJBModuleCon fi > guration.java > > > > Index: EJBModuleConfiguration.java > > =================================================================== > > RCS file: /home/cvs/incubator- > geronimo/modules/core/src/java/org/apache/geronimo/security/EJBModuleCon fi > guration.java,v > > retrieving revision 1.3 > > retrieving revision 1.4 > > diff -u -r1.3 -r1.4 > > --- EJBModuleConfiguration.java 28 Dec 2003 19:34:05 -0000 1.3 > > +++ EJBModuleConfiguration.java 28 Dec 2003 20:13:06 -0000 1.4 > > @@ -80,6 +80,8 @@ > > */ > > public class EJBModuleConfiguration extends > AbstractModuleConfiguration { > > > > + public static final String BASE_OBJECT_NAME = > "geronimo.security:type=EJBModuleConfiguration"; > > + > > public EJBModuleConfiguration(String contextId, EjbJar ejbJar) > throws GeronimoSecurityException { > > super(contextId); > > configure(ejbJar); > > Hi, > > Is it only me who thinks the class shall change its place or name? I'm > rather up for moving the class to Geronimo's EJB module package - > org.apache.geronimo.ejb. It's pretty generic to any EJB implementation, > thus it's not appropriate for Nova. > > Also, I don't like the MBean's name. I'd rather see it as > "geronimo.ejb:type=EJBModuleConfiguration". > > Regardless of what it's going to happen with the class and its MBean > name, my doubts have been reported :-)
I think that it's a good idea to keep the security stuff together. Using this rule of thumb, EJBModuleConfiguration would stay in the o.a.g.security package. As for its MBean name, I feel strongly that all the security MBeans should stay in geronimo.security for similar reasons that I gave above. Regards, Alan
