Cheers,
--jason
On Mar 2, 2004, at 1:13 PM, Dain Sundstrom wrote:
Unless there is truly a common need for a piece of code and the code is tricky, I think we should put it in the common module. Unfortunately, I don't think a timer is not tricky, and it really only seems to be needed by the tests (and I would not call that truly common).
-dain
/************************* * Dain Sundstrom * Partner * Core Developers Network *************************/
On Mar 2, 2004, at 2:59 PM, David Jencks wrote:
I agree that it seems useful. There is also (when last I fixed it) nothing wrong with the test case. However, I have previously spent several hours trying to make the tests pass. I consider this trouble. Apparently many jvm/os combinations (at least os x and win 98) do not have sufficient resolution from System.currentTimeMillis() to provide any useful information for time intervals less than several seconds.
If you want to maintain the tests for this class feel free to bring it back.
david
On Tuesday, March 2, 2004, at 12:39 PM, Jason Dillon wrote:
StopWatch has not caused any trouble and is a useful class. I do not care if you nuke it, as it seems a lot of my code has been tossed into the bit bucket.
But, do not confuse a poorly written test case with a useful class.
--jason
On Mar 2, 2004, at 12:30 PM, David Jencks wrote:
StopWatch is no longer used and has caused enough trouble ==> I removed it.<PGP.sig>
david jencks
On Tuesday, March 2, 2004, at 11:47 AM, Lynch, Peter wrote:
Anita,
I ran these tests several times last night, and got more or less the same
error, each time in different test cases. I changed the value of the TIME
variable from 100 (milliseconds) to 1000, and this seems to have solved the
problem. Maybe there's a problem on Windows 98 platforms with the
Thread.sleep(int millis) call. Does anyone have a view on this? Also,
what's the proper procedure for getting this file changed in cvs?
Thanks, Peter Lynch
-----Original Message----- From: anita kulshreshtha [SMTP:[EMAIL PROTECTED] Sent: Wednesday, March 03, 2004 5:11 AM To: [EMAIL PROTECTED] Subject: RE: What does this mean?
Hi Peter Here are the results of StopWatchTest - Testsuite: org.apache.geronimo.common.StopWatchTest Tests run: 8, Failures: 1, Errors: 0, Time elapsed: 1.1 sec
Testcase: testConstructor took 0.06 sec
Testcase: testConstructorRunning took 0 sec
Testcase: testStartStop took 0.11 sec
Testcase: testTwoStarts took 0.11 sec
Testcase: testTwoStops took 0.16 sec
Testcase: testTwoLaps took 0.22 sec
FAILED
Expected more than one second, not 60
junit.framework.AssertionFailedError: Expected more
than one second, not 60
at
org.apache.geronimo.common.StopWatchTest.testTwoLaps(StopWatchTest .java:12
5)
at
sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorIm pl.java:
39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAc cessorIm
pl.java:25)
Testcase: testTwoLapsTestcase: testReset took 0.11 sec Testcase: testToDuration took 0.16 sec Thanks--- "Lynch, Peter" <[EMAIL PROTECTED]> wrote:Anita <<incubator-geronimo\modules\common\target\test-reports\.Hi Anita,
I also have Win98 second edition, with jdk 1.4.2_03, and am having problems with StopWatchTest. Do you know which test(s) in particular are failing? Your test results can be found in
../../core/src/test/o/a/g/test/protocol/mockproto/Handler.java.I am hoping to investigate this problem during the next week. I'll keep you posted if I find anything.
Cheers, Peter Lynch
[SMTP:[EMAIL PROTECTED]-----Original Message----- From: anita kulshreshtha[EMAIL PROTECTED]Sent: Monday, March 01, 2004 6:33 AM To: [EMAIL PROTECTED];ed.,Subject: Re: What does this mean?
Hi I am getting same error on my windows 98 2ndjdk1.4.2_01. I am also getting "using or extending a deprecated API" error in
theI had to delete StopWatchTest.java, RAR_1_5ConfigBuilderTest.java, RAR_1_0DconfigBeanTest.java forbuild to proceed. TIA
This communication is confidential and may contain privileged material. If you are not the intended recipient you must not use, disclose, copy or retain it. If you have received it in error please immediately notify me by return email and delete the emails. Thank you.
__________________________________ Do you Yahoo!? Yahoo! Search - Find what you're looking for faster http://search.yahoo.com
This communication is confidential and may contain privileged material.
If you are not the intended recipient you must not use, disclose, copy or retain it.
If you have received it in error please immediately notify me by return email
and delete the emails.
Thank you.
PGP.sig
Description: PGP signature
