gerrit-log

Messages by Date

2026/03/19 [L] Change in pysim[master]: docs/put_key: add tutorial that explains how to manage global platfor... fixeria
2026/03/19 [L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support Timur Davydov
2026/03/19 [S] Change in osmo-ci[master]: jobs: add build/manuals JOB_TYPEs for osmo-s1gw fixeria
2026/03/19 [S] Change in ...osmo-s1gw[master]: enb_proxy: signal mme_info() to the enb_registry fixeria
2026/03/19 [XS] Change in ...osmo-s1gw[master]: pfcp_peer: define ?PFCP_ASSOC_SETUP_TIMEOUT fixeria
2026/03/19 [S] Change in ...osmo-s1gw[master]: [REST] EnbItem: expose name of the selected MME fixeria
2026/03/19 [L] Change in ...osmo-s1gw[master]: [REST] Add GET /config endpoint (ConfigRead) fixeria
2026/03/19 [M] Change in ...osmo-s1gw[master]: [REST] Implement PfcpAssoc{Setup,Release} fixeria
2026/03/19 [S] Change in ...osmo-s1gw[master]: enb_proxy: obtain sctp_client sockopts from the env directly fixeria
2026/03/19 [M] Change in ...osmo-s1gw[master]: [REST] Implement eNB/MME selection by addr-port fixeria
2026/03/19 [L] Change in ...osmo-s1gw[master]: doc/manuals: merge doc/osmo-s1gw-cli.md fixeria
2026/03/19 [XS] Change in ...osmo-s1gw[master]: rebar.lock: bump exometer_report_statsd version fixeria
2026/03/19 [S] Change in ...osmo-s1gw[master]: doc/manuals: update MmeItem related info fixeria
2026/03/19 [XS] Change in ...osmo-s1gw[master]: contrib: add jenkins_manuals.sh fixeria
2026/03/19 [S] Change in ...osmo-s1gw[master]: config/sys.config: increase StatsD reporter interval to 10s fixeria
2026/03/19 [L] Change in ...osmo-s1gw[master]: doc/manuals: merge doc/osmo-s1gw-cli.md fixeria
2026/03/19 [M] Change in ...osmo-s1gw[master]: [REST] Implement eNB/MME selection by addr-port fixeria
2026/03/19 [L] Change in osmo-uecups[master]: Use libosmocore netdev fixeria
2026/03/19 [M] Change in libosmocore[master]: netdev: Add API osmo_netdev_del_addr() fixeria
2026/03/19 [L] Change in osmo-uecups[master]: Use libosmocore netns API fixeria
2026/03/19 [M] Change in osmo-uecups[master]: Use osmo_sockaddr everywhere fixeria
2026/03/19 [L] Change in pysim[master]: docs/put_key: add tutorial that explains how to manage global platfor... dexter
2026/03/19 [L] Change in pysim[master]: docs/put_key: add tutorial that explains how to manage global platfor... dexter
2026/03/19 [L] Change in pysim[master]: docs/put_key: add tutorial that explains how to manage global platfor... dexter
2026/03/19 [L] Change in pysim[master]: docs/put_key: add tutorial that explains how to manage global platfor... dexter
2026/03/19 [L] Change in pysim[master]: docs/put_key: add tutorial that explains how to manage global platfor... dexter
2026/03/19 [L] Change in osmo-uecups[master]: Use libosmocore netdev pespin
2026/03/19 [L] Change in osmo-uecups[master]: Use libosmocore netdev pespin
2026/03/19 [M] Change in libosmocore[master]: netdev: Add API osmo_netdev_del_addr() pespin
2026/03/19 [L] Change in osmo-uecups[master]: Use libosmocore netns API pespin
2026/03/19 [M] Change in pysim[master]: transport: change APDU format paradigm dexter
2026/03/19 [M] Change in pysim[master]: transport: change APDU format paradigm dexter
2026/03/19 [M] Change in osmo-uecups[master]: Use osmo_sockaddr everywhere pespin
2026/03/19 [XS] Change in osmo-trx[master]: transceiver: return -EINVAL for invalid SETSLOT Timur Davydov
2026/03/19 [M] Change in ...osmo-s1gw[master]: [REST] Add MME source address/port to EnbItem pespin
2026/03/19 [S] Change in ...osmo-s1gw[master]: doc/manuals: cli: shorten enb_list example table pespin
2026/03/19 [S] Change in osmo-ttcn3-hacks[master]: s1gw: f_REST_*(): use tr_HTTP_RespBody(decmatch T:?) pespin
2026/03/19 [S] Change in osmo-ttcn3-hacks[master]: library/HTTP_Adapter: bail out early on failure pespin
2026/03/19 [S] Change in osmo-ttcn3-hacks[master]: library/HTTP_Adapter: clarify response template restriction pespin
2026/03/19 [L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support pespin
2026/03/19 [M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O pespin
2026/03/18 [M] Change in ...osmo-s1gw[master]: [REST] Add MME source address/port to EnbItem fixeria
2026/03/18 [S] Change in ...osmo-s1gw[master]: doc/manuals: cli: shorten enb_list example table fixeria
2026/03/18 [S] Change in osmo-ttcn3-hacks[master]: library/HTTP_Adapter: clarify response template restriction fixeria
2026/03/18 [S] Change in osmo-ttcn3-hacks[master]: library/HTTP_Adapter: bail out early on failure fixeria
2026/03/18 [S] Change in osmo-ttcn3-hacks[master]: s1gw: f_REST_*(): use tr_HTTP_RespBody(decmatch T:?) fixeria
2026/03/18 [XS] Change in osmo-ccid-firmware[master]: irq: make default IRQ handler Dummy_Handler weak lynxis lazus
2026/03/18 [XS] Change in osmo-asf4-dfu[master]: dfu: set poll timeout to 128 ms to reduce EPIPE errors lynxis lazus
2026/03/18 [L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support Jenkins Builder
2026/03/18 [M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O Timur Davydov
2026/03/18 [M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O Timur Davydov
2026/03/18 [L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support Timur Davydov
2026/03/18 [XS] Change in osmo-trx[master]: transceiver: return -EINVAL for invalid SETSLOT Timur Davydov
2026/03/18 [XS] Change in osmo-ttcn3-hacks[master]: eIM_Tests: align RSP version number in HTTP header dexter
2026/03/18 [L] Change in ...osmo-s1gw[master]: doc/manuals: merge doc/osmo-s1gw-cli.md pespin
2026/03/18 [M] Change in ...osmo-s1gw[master]: [REST] Implement eNB/MME selection by addr-port pespin
2026/03/18 [XS] Change in osmo-trx[master]: transceiver: return -EINVAL for invalid SETSLOT pespin
2026/03/18 [M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O pespin
2026/03/18 [M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O pespin
2026/03/18 [XS] Change in osmo-trx[master]: transceiver: return -EINVAL for invalid SETSLOT pespin
2026/03/18 [M] Change in ...osmo-s1gw[master]: [REST] Implement eNB/MME selection by addr-port fixeria
2026/03/18 [M] Change in ...osmo-s1gw[master]: [REST] Implement PfcpAssoc{Setup,Release} fixeria
2026/03/18 [M] Change in ...osmo-s1gw[master]: [REST] Implement eNB/MME selection by addr-port fixeria
2026/03/18 [S] Change in ...osmo-s1gw[master]: [REST] EnbItem: expose name of the selected MME fixeria
2026/03/18 [L] Change in ...osmo-s1gw[master]: doc/manuals: merge doc/osmo-s1gw-cli.md fixeria
2026/03/18 [M] Change in ...osmo-s1gw[master]: [REST] Add MME source address/port fixeria
2026/03/18 [M] Change in ...osmo-s1gw[master]: [REST] Implement PfcpAssoc{Setup,Release} fixeria
2026/03/18 [L] Change in ...osmo-s1gw[master]: [REST] Add GET /config endpoint (ConfigRead) fixeria
2026/03/18 [S] Change in ...osmo-s1gw[master]: config/sys.config: increase StatsD reporter interval to 10s fixeria
2026/03/18 [S] Change in ...osmo-s1gw[master]: enb_proxy: signal mme_info() to the enb_registry fixeria
2026/03/18 [S] Change in ...osmo-s1gw[master]: [REST] EnbItem: expose name of the selected MME fixeria
2026/03/18 [S] Change in ...osmo-s1gw[master]: enb_proxy: obtain sctp_client sockopts from the env directly fixeria
2026/03/18 [XS] Change in ...osmo-s1gw[master]: pfcp_peer: define ?PFCP_ASSOC_SETUP_TIMEOUT fixeria
2026/03/18 [XS] Change in ...osmo-s1gw[master]: contrib: add jenkins_manuals.sh fixeria
2026/03/18 [XS] Change in ...osmo-s1gw[master]: rebar.lock: bump exometer_report_statsd version fixeria
2026/03/18 [L] Change in ...osmo-s1gw[master]: doc/manuals: merge doc/osmo-s1gw-cli.md fixeria
2026/03/18 [S] Change in ...osmo-s1gw[master]: doc/manuals: update MmeItem related info fixeria
2026/03/18 [L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support Jenkins Builder
2026/03/18 [L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support Timur Davydov
2026/03/18 [M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O Jenkins Builder
2026/03/18 [L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support Timur Davydov
2026/03/18 [L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support Jenkins Builder
2026/03/18 [L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support Timur Davydov
2026/03/18 [M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O Timur Davydov
2026/03/18 [M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O Timur Davydov
2026/03/18 [L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support Timur Davydov
2026/03/18 [XS] Change in osmo-trx[master]: transceiver: return -EINVAL for invalid SETSLOT Timur Davydov
2026/03/18 [L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support Timur Davydov
2026/03/18 [L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support Jenkins Builder
2026/03/18 [L] Change in osmo-trx[master]: transceiver: add optional WebSDR device support Timur Davydov
2026/03/18 [M] Change in ...osmo-s1gw[master]: [REST] Implement eNB/MME selection by addr-port fixeria
2026/03/18 [S] Change in ...osmo-s1gw[master]: config/sys.config: increase StatsD reporter interval to 10s fixeria
2026/03/18 [M] Change in osmo-ttcn3-hacks[master]: s1gw: add tests for MME registry REST procedures fixeria
2026/03/18 [M] Change in osmo-ttcn3-hacks[master]: s1gw: add README.md fixeria
2026/03/18 [S] Change in osmo-ttcn3-hacks[master]: s1gw: use REST interface to check PFCP assoc state fixeria
2026/03/18 [M] Change in osmo-ttcn3-hacks[master]: s1gw: add testcases for impatient eNB during MME pool selection fixeria
2026/03/18 [L] Change in osmo-ttcn3-hacks[master]: s1gw: initial testcases for MME pooling fixeria
2026/03/18 [S] Change in osmo-ttcn3-hacks[master]: s1gw: enable the REST interface, fix wrong REST port fixeria
2026/03/18 [M] Change in osmo-ttcn3-hacks[master]: s1gw: add testcases for impatient eNB during MME pool selection fixeria
2026/03/18 [XS] Change in osmo-ttcn3-hacks[master]: SCCP_Adapter: Fix typo in setverdict string pespin
2026/03/18 [XS] Change in osmo-ttcn3-hacks[master]: 5gc: Update mobility procedure status pespin
2026/03/18 [S] Change in osmo-ttcn3-hacks[master]: 5gc: f_pdu_sess_establish(): Pass pdu sess type as param pespin
2026/03/18 [S] Change in osmo-gsm-manuals[master]: gsup: align ordering of IEs fixeria
2026/03/18 [S] Change in osmo-gsm-manuals[master]: gsup: align ordering of IEs fixeria
2026/03/18 [XS] Change in osmo-bsc[master]: nokia_site: Change the LAPD N200 counter for RSL laforge
2026/03/18 [XS] Change in osmo-bsc[master]: nokia_site: Change the LAPD N200 counter for RSL laforge
2026/03/18 [S] Change in osmo-gsm-manuals[master]: gsup: align ordering of IEs laforge
2026/03/18 [XS] Change in osmo-ttcn3-hacks[master]: 5gc: Update mobility procedure status osmith
2026/03/18 [XS] Change in libosmocore[master]: netdev: netdev_mnl_set_mtu(): drop unneeded variables laforge
2026/03/18 [XS] Change in libosmocore[master]: netdev: netdev_mnl_set_mtu(): drop unneeded variables laforge
2026/03/18 [S] Change in pysim[master]: esim/http_json_api: allow URL rewriting laforge
2026/03/18 [S] Change in pysim[master]: esim/http_json_api: allow URL rewriting laforge
2026/03/18 [M] Change in osmo-ttcn3-hacks[master]: s1gw: add README.md laforge
2026/03/18 [M] Change in osmo-ttcn3-hacks[master]: s1gw: add testcases for impatient eNB during MME pool selection laforge
2026/03/18 [XS] Change in osmo-ttcn3-hacks[master]: SCCP_Adapter: Fix typo in setverdict string laforge
2026/03/18 [XS] Change in osmo-ttcn3-hacks[master]: 5gc: Update mobility procedure status laforge
2026/03/18 [L] Change in ...osmo-s1gw[master]: doc/manuals: merge doc/osmo-s1gw-cli.md laforge
2026/03/18 [XS] Change in pysim[master]: global_platform: fix store_data() returning last chunk only laforge
2026/03/18 [S] Change in pysim[master]: global_platform: install_cap_parser: argument groups cannot be nested laforge
2026/03/18 [M] Change in ...osmo-s1gw[master]: doc/manuals: document the metrics fixeria
2026/03/18 [L] Change in ...osmo-s1gw[master]: doc/manuals: add overview, document running and configuration fixeria
2026/03/18 [L] Change in ...osmo-s1gw[master]: doc/manuals: document the REST interface fixeria
2026/03/18 [M] Change in ...osmo-s1gw[master]: doc/manuals: document GTP-U KPI monitoring fixeria
2026/03/18 [XS] Change in osmo-ttcn3-hacks[master]: SCCP_Adapter: Fix typo in setverdict string pespin
2026/03/18 [XS] Change in osmo-ttcn3-hacks[master]: 5gc: Update mobility procedure status pespin
2026/03/18 [S] Change in osmo-ttcn3-hacks[master]: 5gc: f_pdu_sess_establish(): Pass pdu sess type as param pespin
2026/03/18 [M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O pespin
2026/03/18 [M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O Jenkins Builder
2026/03/18 [M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O pespin
2026/03/18 [XS] Change in osmo-trx[master]: transceiver: return -EINVAL for invalid SETSLOT pespin
2026/03/18 [M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O pespin
2026/03/18 [S] Change in ...osmo-s1gw[master]: [REST] EnbItem: expose name of the selected MME pespin
2026/03/18 [M] Change in ...osmo-s1gw[master]: [REST] Implement PfcpAssoc{Setup,Release} pespin
2026/03/18 [M] Change in ...osmo-s1gw[master]: [REST] Implement eNB/MME selection by addr-port pespin
2026/03/18 [L] Change in ...osmo-s1gw[master]: [REST] Add GET /config endpoint (ConfigRead) pespin
2026/03/18 [S] Change in ...osmo-s1gw[master]: enb_proxy: obtain sctp_client sockopts from the env directly pespin
2026/03/18 [S] Change in ...osmo-s1gw[master]: enb_proxy: signal mme_info() to the enb_registry pespin
2026/03/18 [XS] Change in ...osmo-s1gw[master]: pfcp_peer: define ?PFCP_ASSOC_SETUP_TIMEOUT pespin
2026/03/18 [S] Change in ...osmo-s1gw[master]: config/sys.config: increase StatsD reporter interval to 10s pespin
2026/03/18 [XS] Change in ...osmo-s1gw[master]: rebar.lock: bump exometer_report_statsd version pespin
2026/03/18 [S] Change in ...osmo-s1gw[master]: doc/manuals: update MmeItem related info pespin
2026/03/18 [L] Change in ...osmo-s1gw[master]: doc/manuals: merge doc/osmo-s1gw-cli.md pespin
2026/03/18 [L] Change in ...osmo-s1gw[master]: doc/manuals: document the REST interface pespin
2026/03/18 [M] Change in ...osmo-s1gw[master]: doc/manuals: document GTP-U KPI monitoring pespin
2026/03/18 [M] Change in ...osmo-s1gw[master]: doc/manuals: document the metrics pespin
2026/03/18 [L] Change in ...osmo-s1gw[master]: doc/manuals: add overview, document running and configuration pespin
2026/03/18 [S] Change in ...osmo-s1gw[master]: [REST] EnbItem: expose name of the selected MME osmith
2026/03/18 [M] Change in ...osmo-s1gw[master]: [REST] Implement PfcpAssoc{Setup,Release} osmith
2026/03/18 [S] Change in pysim[master]: global_platform: refactor gen_install_parameters() fixeria
2026/03/18 [M] Change in ...osmo-s1gw[master]: [REST] Implement eNB/MME selection by addr-port osmith
2026/03/18 [L] Change in ...osmo-s1gw[master]: [REST] Add GET /config endpoint (ConfigRead) osmith
2026/03/18 [S] Change in ...osmo-s1gw[master]: enb_proxy: obtain sctp_client sockopts from the env directly osmith
2026/03/18 [S] Change in ...osmo-s1gw[master]: enb_proxy: signal mme_info() to the enb_registry osmith
2026/03/18 [XS] Change in ...osmo-s1gw[master]: pfcp_peer: define ?PFCP_ASSOC_SETUP_TIMEOUT osmith
2026/03/18 [S] Change in ...osmo-s1gw[master]: config/sys.config: increase StatsD reporter interval to 10s osmith
2026/03/18 [XS] Change in ...osmo-s1gw[master]: rebar.lock: bump exometer_report_statsd version osmith
2026/03/18 [S] Change in ...osmo-s1gw[master]: doc/manuals: update MmeItem related info osmith
2026/03/18 [L] Change in ...osmo-s1gw[master]: doc/manuals: merge doc/osmo-s1gw-cli.md osmith
2026/03/18 [L] Change in ...osmo-s1gw[master]: doc/manuals: document the REST interface osmith
2026/03/18 [M] Change in ...osmo-s1gw[master]: doc/manuals: document GTP-U KPI monitoring osmith
2026/03/18 [M] Change in ...osmo-s1gw[master]: doc/manuals: document the metrics osmith
2026/03/18 [L] Change in ...osmo-s1gw[master]: doc/manuals: add overview, document running and configuration osmith
2026/03/17 [L] Change in ...osmo-s1gw[master]: [REST] Add GET /config endpoint (ConfigRead) fixeria
2026/03/17 [S] Change in ...osmo-s1gw[master]: [REST] EnbItem: expose name of the selected MME fixeria
2026/03/17 [M] Change in ...osmo-s1gw[master]: [REST] Implement eNB/MME selection by addr-port fixeria
2026/03/17 [S] Change in ...osmo-s1gw[master]: enb_proxy: obtain sctp_client sockopts from the env directly fixeria
2026/03/17 [M] Change in ...osmo-s1gw[master]: [REST] Implement PfcpAssoc{Setup,Release} fixeria
2026/03/17 [S] Change in ...osmo-s1gw[master]: enb_proxy: signal mme_info() to the enb_registry fixeria
2026/03/17 [XS] Change in ...osmo-s1gw[master]: pfcp_peer: define ?PFCP_ASSOC_SETUP_TIMEOUT fixeria
2026/03/17 [L] Change in ...osmo-s1gw[master]: [REST] Add GET /config endpoint (ConfigRead) fixeria
2026/03/17 [L] Change in osmo-ttcn3-hacks[master]: s1gw: initial testcases for MME pooling fixeria
2026/03/17 [M] Change in osmo-ttcn3-hacks[master]: s1gw: add tests for MME registry REST procedures fixeria
2026/03/17 [XS] Change in ...osmo-s1gw[master]: rebar.lock: bump exometer_report_statsd version fixeria
2026/03/17 [XS] Change in ...osmo-s1gw[master]: rebar.lock: bump exometer_report_statsd version fixeria
2026/03/17 [M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_secondary_rat_data_usage_report pespin
2026/03/17 [M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_secondary_rat_data_usage_report pespin
2026/03/17 [S] Change in osmo-ttcn3-hacks[master]: 5gc: Document multiple inter RAT procedures not implemented pespin
2026/03/17 [XS] Change in osmo-ttcn3-hacks[master]: NGAP_Templates: Fix wrong IE id in n2_PDUSessionResourceModifyConfirm pespin
2026/03/17 [M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_ran_initiated_qos_flow_mobility pespin
2026/03/17 [XS] Change in osmo-ttcn3-hacks[master]: 5gc: Remove conditional check for nightly repo in TC_pdu_sess_modific... pespin
2026/03/17 [XS] Change in osmo-ttcn3-hacks[master]: 5gc: Document Location Services as not implemented by open5gs pespin
2026/03/17 [M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_normal_reg_emergency_services_fallback pespin
2026/03/17 [S] Change in osmo-ttcn3-hacks[master]: 5gc: Document 'SMS over NAS' procedures as not implemented by open5gs pespin
2026/03/17 [M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_ran_initiated_qos_flow_mobility pespin
2026/03/17 [S] Change in pysim[master]: global_platform: install_cap_parser: argument groups cannot be nested fixeria
2026/03/17 [S] Change in ...osmo-s1gw[master]: config/sys.config: increase StatsD reporter interval to 10s fixeria
2026/03/17 [S] Change in ...osmo-s1gw[master]: config/sys.config: increase StatsD reporter interval to 10s fixeria
2026/03/17 [S] Change in osmo-ttcn3-hacks[master]: 5gc: f_pdu_sess_establish(): Pass pdu sess type as param fixeria
2026/03/17 [XS] Change in pysim[master]: utils: DataObjectCollection.encode(): fix TypeError fixeria
2026/03/17 [XS] Change in pysim[master]: ts_31_102: fix description for EF_5GS3GPPLOCI fixeria
2026/03/17 [XS] Change in pysim[master]: ts_31_102: EF_5G_PROSE_UIR: fix copy-pasted inner class name fixeria
2026/03/17 [XS] Change in pysim[master]: ts_51_011: EF.EXT[6-7]: fix typo in desc fixeria
2026/03/17 [XS] Change in pysim[master]: cdma_ruim: fix inaccurate comment for EF_AD fixeria
2026/03/17 [XS] Change in pysim[master]: esim/saip: raise an exception properly fixeria
2026/03/17 [XS] Change in pysim[master]: utils: dec_plmn(): remove redundant call fixeria
2026/03/17 [XS] Change in pysim[master]: ara_m: fix undefined variable used in a format-string fixeria
2026/03/17 [S] Change in pysim[master]: global_platform: install_cap_parser: argument groups cannot be nested fixeria
2026/03/17 [S] Change in pysim[master]: sms: fix flags_construct in SMS_DELIVER fixeria
2026/03/17 [XS] Change in pysim[master]: ota: OtaAlgo{Crypt,Auth}: fix algo_auth vs algo_crypt fixeria
2026/03/17 [S] Change in pysim[master]: ara_m: fix exceptions not being raised properly fixeria