Patch Set 1: -Code-Review (3 comments)
https://gerrit.osmocom.org/#/c/2056/1/openbsc/include/openbsc/pcu_if.h File openbsc/include/openbsc/pcu_if.h: Line 13: struct osmo_fd conn_bfd; /* fd for connection to lcr */ to lrc?!? https://gerrit.osmocom.org/#/c/2056/1/openbsc/src/libbsc/bsc_init.c File openbsc/src/libbsc/bsc_init.c: Line 534: strcpy(pcu_sock_path, PCU_SOCK_DEFAULT); osmo_strlcpy for bounds checking? https://gerrit.osmocom.org/#/c/2056/1/openbsc/src/libbsc/pcu_sock.c File openbsc/src/libbsc/pcu_sock.c: Line 1: /* pcu_sock.c: Connect from PCU via unix domain socket */ the question here is still if this code could/should be generalized and shared between the PCU socket inside the BTS and the one inside the BSC. -- To view, visit https://gerrit.osmocom.org/2056 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib13cb4099d12fa71e9e0b8727e19ab29e11909b2 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
