Patch Set 1: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/2071/1/src/encoding.cpp File src/encoding.cpp: Line 380: pcu_tx_txt_ind(PCU_OML_ALERT, "PCU: length of IMM.ASS without " we are sending the message over the PCU socket, so it is clear that it originates from the PCU. Any forwarding of this message from BTS to BSC should preserve this information (originating from PCU, not from BTS) in machine-parseable way somehow. And before it is printed, the printer can use this to prefix with PCU. I don't like to have a "PCU:" string here. and have other code in other network elements rely on it. -- To view, visit https://gerrit.osmocom.org/2071 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4ea5b3f7409df2fb030681ad468df6b711790a7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-HasComments: Yes
