Patch Set 2:

(1 comment)

> (1 comment)

https://gerrit.osmocom.org/#/c/2142/2/CommonLibs/BitVector.h
File CommonLibs/BitVector.h:

Line 305:               return (*dp)>0.0F;
> Can we just compare "> 0" in here?
Yes, but I want to make it clear it's a floating point value.


-- 
To view, visit https://gerrit.osmocom.org/2142
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ecc3d4c829dcf0f619ad995bc9d4a4ed8af0a4
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Alexander Chemeris <alexander.cheme...@gmail.com>
Gerrit-Reviewer: Alexander Chemeris <alexander.cheme...@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Tom Tsou <t...@tsou.cc>
Gerrit-HasComments: Yes

Reply via email to