Patch Set 2: > Maybe we can replace both -r and -E with new --filler which will > figure out appropriate filler based on other options by checking if > edge is enabled or not?
That's exactly what this patch is moving away from. Right now -r option has different behavior based on whether -e is specified or not, which means that I can't generate random GMSK burst if I run in EDGE mode, which is very inconvenient. What we can do is to make this a control interface command rather than a command line parameter. It'll make it harder to use, but more clean from the code perspective. -- To view, visit https://gerrit.osmocom.org/2143 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8808bbe3f06740ef3fec1d1865ecb57fbcfabab Gerrit-PatchSet: 2 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: Alexander Chemeris <alexander.cheme...@gmail.com> Gerrit-Reviewer: Alexander Chemeris <alexander.cheme...@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Tom Tsou <t...@tsou.cc> Gerrit-HasComments: No
