Patch Set 1: > AX_EXT is macro from autoconf-archive package - I think it's avery > bad idea to supply our own modified copy: this means we'll have to > track all upstream fixes manually. I think we should either move > this code directly to configure.ac or add our own macro wrapping > ax_ext. If neither possible we should at the very least explicitly > mention from which version of autoconf-archive this was > copy-pasted.
I guess simply rename it or merge into configure.ac is fine. I don't thin we need or want to track any upstream changes, as what we are doing now is quite different from upstream. -- To view, visit https://gerrit.osmocom.org/2134 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I846e190e92f1258cd412d1b2d79b539e204e04b3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: No
