Patch Set 1: Code-Review+1 (1 comment)
https://gerrit.osmocom.org/#/c/2162/1/src/common/vty.c File src/common/vty.c: Line 271: osmo_str2lower(buf_casecnvt, get_value_string(gsmtap_sapi_names, i)); hmm the osmo_str2lower() API is a bit unfortunate: no size checks. We should check the size separately. The local implementation checked that buf_casecnvt is large enough. Admitted, it's super unlikely that gsmtap_sapi_names entries will be > 256, in fact 6 would suffice. So this is more about coding style than real failure... what do you think? -- To view, visit https://gerrit.osmocom.org/2162 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7faced2eaf0f6f87f06081235eea9d4c3ba71a7e Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
