Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/2176/2/src/gsm/gsm0808_utils.c File src/gsm/gsm0808_utils.c: Line 72: struct sockaddr_storage *gsm0808_dec_aoip_trasp_addr(const void *ctx, in genera we try to avoid dynamic allcoations whenever it is not needed, So I guess a more natural way to do this is to pass a caller-allocated 'struct sockaddr_storage *' as argument into the function. This way, the caller can pass the address-of a member structure of some internal state into the decoder. -- To view, visit https://gerrit.osmocom.org/2176 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57933b0a06a3f54ec2a41e6ecb6ced9fbbc89332 Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
