Harald Welte has submitted this change and it was merged.
Change subject: compiler warnings: take care of compiler warning "unused-result"
......................................................................
compiler warnings: take care of compiler warning "unused-result"
Though it makes no sense to handle the return code of freopen() here,
the compiler complains about it. The #pragma statements take care of
that.
Change-Id: Ia2caadbed2a24f84d1d55a47236b398b74224e82
---
M src/application.c
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
Holger Freyther: Looks good to me, approved
diff --git a/src/application.c b/src/application.c
index 4112e75..6a18d0e 100644
--- a/src/application.c
+++ b/src/application.c
@@ -156,9 +156,16 @@
/* Redirect stdio to /dev/null */
/* since C89/C99 says stderr is a macro, we can safely do this! */
#ifdef stderr
+/*
+ * it does not make sense to check the return code here, so we just
+ * ignore the compiler warning from gcc
+ */
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-result"
freopen("/dev/null", "r", stdin);
freopen("/dev/null", "w", stdout);
freopen("/dev/null", "w", stderr);
+#pragma GCC diagnostic pop
#endif
return 0;
--
To view, visit https://gerrit.osmocom.org/2045
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2caadbed2a24f84d1d55a47236b398b74224e82
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Thorsten Alteholz <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Holger Freyther <[email protected]>
Gerrit-Reviewer: Jenkins Builder
