[PATCH] libosmo-sccp[master]: osmo_ss7: Fix msgb memory leaks in error paths (asp not conn...

[Harald Welte]

Review at  https://gerrit.osmocom.org/2267

osmo_ss7: Fix msgb memory leaks in error paths (asp not connected)

Change-Id: I031d90348ea243ac5dbdde14365528f3ec8e3709
---
M src/osmo_ss7.c
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/67/2267/1

diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index fb1cbc4..103c05b 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1421,6 +1421,7 @@
                if (!asp->server) {
                        LOGPASP(asp, DLSS7, LOGL_ERROR, "Cannot transmit, no 
asp->server\n");
                        /* FIXME: what to do here? delete the route? send DUNA? 
*/
+                       msgb_free(msg);
                        return -EIO;
                }
                osmo_stream_srv_send(asp->server, msg);
@@ -1428,6 +1429,7 @@
                if (!asp->client) {
                        LOGPASP(asp, DLSS7, LOGL_ERROR, "Cannot transmit, no 
asp->client\n");
                        /* FIXME: what to do here? delete the route? send DUNA? 
*/
+                       msgb_free(msg);
                        return -EIO;
                }
                osmo_stream_cli_send(asp->client, msg);

-- 
To view, visit https://gerrit.osmocom.org/2267
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I031d90348ea243ac5dbdde14365528f3ec8e3709
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>