Patch Set 3: (1 comment)
https://gerrit.osmocom.org/#/c/2253/3/src/datagram.c File src/datagram.c: PS3, Line 196: osmo_sock_init2 > This will not always set conn->ofd to -1. There are error paths before crea Thanks for your review! Howeveer, if it was >= 0 a few lines above, we would have called osmo_dgram_tx_close() which would have set it to -1. Or did I misinterpret your comment? -- To view, visit https://gerrit.osmocom.org/2253 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29c37da6e8f5be8ab030e68952a8f92add146821 Gerrit-PatchSet: 3 Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
