Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/2288/2/src/common/pcu_sock.c File src/common/pcu_sock.c: Line 673: osmo_signal_dispatch(SS_FAIL, OSMO_EVT_PCU_VERS, ""); Why "" as signal_data? What happens if NULL is sent? -- To view, visit https://gerrit.osmocom.org/2288 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41a731bd719aee0bbb98d3236405fb3a7f3ddec0 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
