[PATCH] osmo-bts[master]: measurement: Improve log output

[dexter]

Review at  https://gerrit.osmocom.org/2389

measurement: Improve log output

The debug log does not print much information about the measured
rxlev and rxqual values. This commit adds debug output to make
measurement debugging simpler

Change-Id: Ic871eed6dcbc7d10aca6cd11dbc803b3e6da449f
---
M src/common/measurement.c
M src/common/rsl.c
2 files changed, 26 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/2389/1

diff --git a/src/common/measurement.c b/src/common/measurement.c
index 8076413..9987d73 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -99,6 +99,11 @@
                rc = 0;
                break;
        }
+
+       DEBUGP(DMEAS,
+              "MEAS PERIOD END status:%d for chan:%u, TS:%u, SUBCHAN:%u, 
FN:%u, FN_MOD:%u\n",
+              rc, pchan, ts, subch, fn, fn_mod);
+
        return rc;
 }
 
@@ -219,6 +224,14 @@
        mru->full.rx_qual = ber10k_to_rxqual(ber_full_sum);
        mru->sub.rx_qual = ber10k_to_rxqual(ber_sub_sum);
 
+       DEBUGP(DMEAS, "%s UL MEAS RXLEV_FULL(%u), RXLEV_SUB(%u),"
+              "RXQUAL_FULL(%u), RXQUAL_SUB(%u), num_meas_sub(%u), 
num_ul_meas(%u) \n",
+              gsm_lchan_name(lchan),
+              mru->full.rx_lev,
+              mru->sub.rx_lev,
+              mru->full.rx_qual,
+              mru->sub.rx_qual, num_meas_sub, lchan->meas.num_ul_meas);
+
        lchan->meas.flags |= LC_UL_M_F_RES_VALID;
        lchan->meas.num_ul_meas = 0;
 
diff --git a/src/common/rsl.c b/src/common/rsl.c
index 1d0bcea..a542324 100644
--- a/src/common/rsl.c
+++ b/src/common/rsl.c
@@ -2228,8 +2228,9 @@
        uint8_t chan_nr = gsm_lchan2chan_nr(lchan);
        int res_valid = lchan->meas.flags & LC_UL_M_F_RES_VALID;
 
-       LOGP(DRSL, LOGL_DEBUG, "%s Tx MEAS RES valid(%d)\n",
-               gsm_lchan_name(lchan), res_valid);
+       LOGP(DRSL, LOGL_DEBUG,
+            "%s chan_num:%d Tx MEAS RES valid(%d), flags(%d)\n",
+            gsm_lchan_name(lchan), chan_nr, res_valid, lchan->meas.flags);
 
        if (!res_valid)
                return -EINPROGRESS;
@@ -2238,6 +2239,16 @@
        if (!msg)
                return -ENOMEM;
 
+       LOGP(DRSL, LOGL_DEBUG,
+            "Send Meas RES: NUM:%d, RXLEV_FULL:%d, RXLEV_SUB:%d, 
RXQUAL_FULL:%d, RXQUAL_SUB:%d, MS_PWR:%d, UL_TA:%d, L3_LEN:%d, TimingOff:%u\n",
+            lchan->meas.res_nr,
+            lchan->meas.ul_res.full.rx_lev,
+            lchan->meas.ul_res.sub.rx_lev,
+            lchan->meas.ul_res.full.rx_qual,
+            lchan->meas.ul_res.sub.rx_qual,
+            lchan->meas.l1_info[0],
+            lchan->meas.l1_info[1], l3_len, lchan->meas.ms_timing_offset);
+
        msgb_tv_put(msg, RSL_IE_MEAS_RES_NR, lchan->meas.res_nr++);
        size_t ie_len = gsm0858_rsl_ul_meas_enc(&lchan->meas.ul_res,
                                                lchan->tch.dtx.dl_active,

-- 
To view, visit https://gerrit.osmocom.org/2389
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic871eed6dcbc7d10aca6cd11dbc803b3e6da449f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pma...@sysmocom.de>