[PATCH] libosmo-sccp[master]: deliver_to_mtp_user(): Fix null pointer dereference

[Harald Welte]

Review at  https://gerrit.osmocom.org/2431

deliver_to_mtp_user(): Fix null pointer dereference

We had used + derefernced the 'prim' pointer before checking its
validity.

Change-Id: I0ca5026091e91926924b297f9342bda5f9fd38c9
Fixes: coverity CID#166946
---
M src/osmo_ss7_hmrt.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/31/2431/1

diff --git a/src/osmo_ss7_hmrt.c b/src/osmo_ss7_hmrt.c
index bbbb3a9..393530a 100644
--- a/src/osmo_ss7_hmrt.c
+++ b/src/osmo_ss7_hmrt.c
@@ -67,9 +67,9 @@
 
        /* Create MTP-TRANSFER.ind and feed to user */
        prim = m3ua_to_xfer_ind(xua);
-       prim->u.transfer = xua->mtp;
        if (!prim)
                return -1;
+       prim->u.transfer = xua->mtp;
 
        return osu->prim_cb(&prim->oph, (void *) osu->priv);
 }

-- 
To view, visit https://gerrit.osmocom.org/2431
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ca5026091e91926924b297f9342bda5f9fd38c9
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>