Patch Set 1: Code-Review+1 we should introduce a test case at the same time we fix this, just to validate the old code was wrong, the new code works, and that future versions will not introduce regressions. It should be as straight-forward as to checking against a valid and an invalid FR SID frame from a const uint8_t[] array. If yo can give me some valid FR SID samples, I'd volunteer to write the test case.
-- To view, visit https://gerrit.osmocom.org/2441 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I45d98c6edf267f313883503a65385190ffbc65ca Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: jfdionne <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No
