Patch Set 4: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/#/c/2102/4/config/ax_ext.m4
File config/ax_ext.m4:

Line 22: #     HAVE_MMX / HAVE_SSE / HAVE_SSE2 / HAVE_SSE3 / HAVE_SSSE3 / 
HAVE_SSE4.1 / HAVE_SSE4.2 / HAVE_AVX
Now we have only HAVE_SSE3 and HAVE_SSE4.1, right?
So, it would be good to update this line with actual info.


PS4, Line 47: AC_REQUIRE([AX_GCC_X86_CPUID])
            :       AC_REQUIRE([AX_GCC_X86_AVX_XGETBV])
            : 
            :       AX_GCC_X86_CPUID(0x00000001)
Do we still need this?


-- 
To view, visit https://gerrit.osmocom.org/2102
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic913aa13c23c348ae62e78c9dfd6ed8b0a62798c
Gerrit-PatchSet: 4
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-HasComments: Yes

Reply via email to