Patch Set 2: Code-Review+2 (1 comment)
https://gerrit.osmocom.org/#/c/2084/2/include/osmocom/core/logging.h File include/osmocom/core/logging.h: Line 335: const char *log_vty_command_string() OSMO_DEPRECATED("For internal use inside libosmocore only."); you could introduce a libosmovty.map file that selectively exports only the public API and thus permits for such internal symbols in a clean way, like we do it in libosmogb and libosmogsm. -- To view, visit https://gerrit.osmocom.org/2084 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e9ddd7ba3ce211302d99a3494eb408907a2916e Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
