Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/2548/1/m4/ax_check_simd.m4 File m4/ax_check_simd.m4: Line 44: AM_CONDITIONAL(HAVE_AVX2, false) > QEMU: Great! Odd: Why do you think so? Original macro used to check whether *both* CPU and compiler do support some set of SIMD features. But, since we decided to use runtime SIMD detection, we don't need to check, whether CPU of build machine supports required SIMD anymore. So, this is why cpuid related functionality was cut out. And right now this is a small part of original macro, which only checks if compiler supports defined SIMD flags. Honestly, it isn't my own idea - I used dexter's recent changes of OsmoTRX as an example and just replicated his a bit mistaken way of AM_CONDITIONAL variable definition. I already notified him about that. -- To view, visit https://gerrit.osmocom.org/2548 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0c3128f9768f95c1f5f955db242e71c81384c6c Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Holger Freyther <hol...@freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-HasComments: Yes
