Patch Set 3: Code-Review-1 (3 comments)
https://gerrit.osmocom.org/#/c/2588/3/openbsc/src/libbsc/rest_octets.c File openbsc/src/libbsc/rest_octets.c: PS3, Line 192: ) where does the magic number 25 originate from? https://gerrit.osmocom.org/#/c/2588/3/openbsc/src/libbsc/system_information.c File openbsc/src/libbsc/system_information.c: PS3, Line 674: s this needs documentation in the code. The name implies that si2q is not needed. but why would it not be needed? Line 691: size_t earfcn_num(const struct osmo_earfcn_si2q *e) does it return an EARFCN Number (the EARFCN) or rather the count of EARFCN? In latter caes, it might be better to rename it. Also, as the function is non-static, it might make sense to call it si2q_count_earfcn or si2q_earfcn_count to give it some significance in the global namespace. -- To view, visit https://gerrit.osmocom.org/2588 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib554cf7ffc949a321571e1ae2ada1160e1b35fa6 Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
