Patch Set 1: > How was this found? Is there specific test case we might add which > fails with old code but works with new one?
This was found by cppcheck: "unreachable part of code". My assumption is that the TVLV_GROSS_LEN was merely copy-pasted to VTVLV_GAN_GROSS_LEN, and return statements were out of code writer's attention. Otherwise, why do we need another function, which works the same way like old one? -- To view, visit https://gerrit.osmocom.org/2592 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id52ddd8358fd4af1ecc71142deb09f1e237021f3 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-HasComments: No
