Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/2600/2/src/osmo_gsm_tester/trial.py
File src/osmo_gsm_tester/trial.py:

Line 77:         self.log('Detailed log at', detailed_log)
> join this logging with the one above it?
I considered it, but adding the long abspath to the 'Trial start' message would 
make it harder to see. I prefer the 'Trial start' to stand out on its own... is 
that ok with you?


-- 
To view, visit https://gerrit.osmocom.org/2600
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5f443f1af0dc774d4d4c588a238b786a83e44d3
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-HasComments: Yes

Reply via email to