Patch Set 1: Code-Review+1 (3 comments)
(cosmetics) https://gerrit.osmocom.org/#/c/2585/1/src/osmo_gsm_tester/bts_octphy.py File src/osmo_gsm_tester/bts_octphy.py: Line 57: '-i', self.nitb.addr()) (the oct bts is not working and we're not going to make it work at this time, but ok to remember this here) https://gerrit.osmocom.org/#/c/2585/1/src/osmo_gsm_tester/bts_sysmo.py File src/osmo_gsm_tester/bts_sysmo.py: Line 84: remote_cwd=remote_run_dir) indenting chaos ... before, it indented by 4 spaces (+ 1 inside the 2nd-level braces), now the last line is left at 4 while the rest is re-indented, and the 2nd-level brace is flattened with the rest. I'd prefer to keep the patch minimal, i.e. simply and only add the '-i' argument while keeping the cosmetics as they were. https://gerrit.osmocom.org/#/c/2585/1/src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl File src/osmo_gsm_tester/templates/osmo-bts-trx.cfg.tmpl: Line 35: gsmtap-sapi sacch interesting, there already were gsmtap directives in here :) -- To view, visit https://gerrit.osmocom.org/2585 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I057a83bc20c5e664ac1778812452f189166919ba Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
