Patch Set 1:

while these kind of cleanup patches are definitely appreciated, it is very 
difficult to merge them in absence of good unit testing for the related code, 
so we can verify there are no unwanted changes slipping between the cracks from 
the old behavior to the new behavior

-- 
To view, visit https://gerrit.osmocom.org/2654
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fee0714453d0c3c3f3f875f88daea2d9c477331
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

Reply via email to