Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2414
to look at the new patch set (#3).
measurement: Compute measurement results on measurement idication
Computing the measurement results on in l1sap_info_time_ind() all
at once may peak the host CPU. On smaller systems (arm based
sysmobts) this might cause a noticable delay of other important
tasks (e.g. passing l2 messages back and forth) It makes more
sense to compute the measurement results continously when
l1sap_info_meas_ind() is executed.
Change-Id: Iecb9a30c0d716bfc88221cd752b1ffdc74269e30
---
M src/common/l1sap.c
1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/14/2414/3
diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 6c509e3..d79069d 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -415,11 +415,6 @@
/* Update time on PCU interface */
pcu_tx_time_ind(info_time_ind->fn);
- /* check if the measurement period of some lchan has ended
- * and pre-compute the respective measurement */
- llist_for_each_entry(trx, &bts->trx_list, list)
- trx_meas_check_compute(trx, info_time_ind->fn - 1);
-
/* increment number of RACH slots that have passed by since the
* last time indication */
btsb->load.rach.total +=
@@ -478,6 +473,10 @@
lchan_new_ul_meas(lchan, &ulm);
+ /* Check measurement period end and prepare the UL measurment
+ * report at Meas period End*/
+ lchan_meas_check_compute(lchan, info_meas_ind->fn);
+
return 0;
}
--
To view, visit https://gerrit.osmocom.org/2414
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iecb9a30c0d716bfc88221cd752b1ffdc74269e30
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
