Patch Set 1: Code-Review-1
> it is indeed duplicate. However, why did the original author
> introduce that second else clause? I think it is likely that thre
> is a typo in the condition, i.e. the spec has two cases in which we
> should generate a '+'. Please check the spec and see if the proper
> fix is to have that else clause, but with a different condition.
You're right. In gsm411_sms.c I found the following:
if (((smsp[1] & 0x70) >> 4) == 1)
strcpy(gsms->address, "+");
else if (((smsp[1] & 0x70) >> 4) == 2)
strcpy(gsms->address, "0");
else
gsms->address[0] = '\0';
--
To view, visit https://gerrit.osmocom.org/2662
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23287c0f31bee9c1b710f17f932633d2c621dab0
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-HasComments: No
