Patch Set 4: > this should be merged in 2410. I think there's little point in > first adding a (known) wrong table and then fix it up in a later > commit?
2416 (this commit) touches the following lookup tables. These tables were already they. They just get the offeset added: static const uint8_t tchf_meas_rep_fn104[] static const uint8_t tchh0_meas_rep_fn104[] static const uint8_t tchh1_meas_rep_fn104[] 2410 adds two more tables, which are completely new: static const uint8_t sdcch8_meas_rep_fn102[] static const uint8_t sdcch4_meas_rep_fn102[] So the patch set fixes thre tables and adds two more. I am not sure if merging the commits still makes sense, since technically it is separate. However, the scope of the two commits is very close to one another. What do you think? Do we still merge 2416 with 2410? -- To view, visit https://gerrit.osmocom.org/2416 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I471a767c7974bdacadc3233d0c3e7b7965f6eafa Gerrit-PatchSet: 4 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: No
