Patch Set 9: Code-Review+1 (1 comment)
https://gerrit.osmocom.org/#/c/2454/9/src/viterbi_gen.c File src/viterbi_gen.c: Line 132: int16_t *osmo_conv_vdec_malloc(size_t n) actually, it might make sense in a follow-up patch to use talloc here. We generally ues talloc from libosmo* and discourage any direct access to malloc. But that's of course unrelated to this patch subject. -- To view, visit https://gerrit.osmocom.org/2454 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1da6d71ed0564f1d684f3a836e998d09de5f0351 Gerrit-PatchSet: 9 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Alexander Chemeris <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Tom Tsou <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
