Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/2693/1/src/gb/libosmogb.map
File src/gb/libosmogb.map:

Line 41: gprs_signal_ns_names;
all other NS realted symbols are prefixed 'gprs_ns_', yours is not. Please try 
to align with existing conventions.


-- 
To view, visit https://gerrit.osmocom.org/2693
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id664355eb8305fb287e4dae0800fb20dc2f9b8cd
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to