Patch Set 2: Code-Review+2 (2 comments)
https://gerrit.osmocom.org/#/c/2718/2/contrib/jenkins-build-osmo-hlr.sh File contrib/jenkins-build-osmo-hlr.sh: Line 11: have_repo() { In future patches we should move this functions (have_repo, build repo) to a unique file and import it in all build scripts from contrib/ Line 54: build_repo libosmocore I guess we are now building libosmocore for each of the binaries. We should avoid doing that and build dependencies once right? To be done for later tasks too. -- To view, visit https://gerrit.osmocom.org/2718 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07ca99c57eb1c47a3f83673502c8ec638e7e42b2 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
