Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/2715/2/src/osmo_gsm_tester/bts_osmotrx.py
File src/osmo_gsm_tester/bts_osmotrx.py:

Line 47:         return '127.0.0.1'
> You can just do as in sysmobts,  conf.get('addr') then set it to 127.0.0.1 
the point is that this address should be reserved from the ip_address resource 
pool. ATM it is implicitly ending up to be this address, and it is not 
configured anywhere (i.e. does not appear in the osmo-bts-trx.cfg file). Adding 
it to the default config would only add an unused/misleading item. Adding the 
configuration properly isn't a lot of work, only that's not related to this 
patch and should happen separately. For the time being I need some address here.


-- 
To view, visit https://gerrit.osmocom.org/2715
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7af9275914f34808cb60ae16b65ecd3688fd6b5b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-HasComments: Yes

Reply via email to