Patch Set 3: I think it'a better to use a different extension for the include file - not .c. In C++ you would use .ipp (inline cpp) extension, but I don't know whether a similar thing exist in C. See e.g. http://julio.meroh.net/2013/12/header-files-c-ipp-files.html for the way it's used in C++.
-- To view, visit https://gerrit.osmocom.org/2760 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I042cc76258df7e4c6c90a73af3d0a6e75999b2b0 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Alexander Chemeris <alexander.cheme...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Tom Tsou <t...@tsou.cc> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: tnt <t...@246tnt.com> Gerrit-HasComments: No