Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/2734/1/src/osmo_gsm_tester/ofono_client.py File src/osmo_gsm_tester/ofono_client.py: Line 299: if hasattr(to_msisdn, 'msisdn'): > if it's a modem why not just checking isinstance(modem "Modem") instead for The intention was to make use of python's vague typing, to not require a specific class but just the members that are used; and at the same time allow passing a phone nr as string. I see what you mean, we have no use case for any other class than a Modem, meaning that this vague code has no benefit to make up for the drawback of ambiguity. -- To view, visit https://gerrit.osmocom.org/2734 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66b8f30303e21ad781d16f3aa9fe30067d6a0e20 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes
