Patch Set 1: (2 comments)
https://gerrit.osmocom.org/#/c/2765/1//COMMIT_MSG Commit Message: PS1, Line 7: W > I this is still WIP, I am not sure it should be submitted to gerit? If it's I thought it's better to discuss it here with the code/patch in front of us. I can probably move the discussion to the mailing list if you think this is not the right place. Line 9: Otherwise we detect bursts with search window far beyond specified. > specified by whom / where? Would be good to have a spec reference here. Specified by the max_toa variable. -- To view, visit https://gerrit.osmocom.org/2765 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3cb40d2311504a13c03e1fbccad663ac201d9a4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Owner: Alexander Chemeris <alexander.cheme...@gmail.com> Gerrit-Reviewer: Alexander Chemeris <alexander.cheme...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Tom Tsou <t...@tsou.cc> Gerrit-HasComments: Yes