Patch Set 3: Code-Review-1 (2 comments)
https://gerrit.osmocom.org/#/c/2745/3/src/osmo-bts-trx/trx_vty.c File src/osmo-bts-trx/trx_vty.c: Line 487: if (plink->u.osmotrx.local_ip) we have osmo_talloc_replace_string() for this. Line 492: talloc_free(plink->u.osmotrx.remote_ip); same here again, please use osmo_talloc_replace_string() which all related VTY code should already be using whenever assigning strign members via vty. -- To view, visit https://gerrit.osmocom.org/2745 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bd34b7b02c1a9b0c6f6f89f327b486e5620c8d5 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
