Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/2784/2/src/osmo-bts-sysmo/l1_if.c File src/osmo-bts-sysmo/l1_if.c: Line 1878: talloc_asprintf(pinst->version, "%u.%u dsp %u.%u.%u fpga %u.%u.%u", char* talloc_asprintf ( const void * t, const char * fmt, ... ) so passing pinst->version as a context doesn't look good.. and ignoring the allocation is ... -- To view, visit https://gerrit.osmocom.org/2784 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b2352b8d15e9b0d8616fcd526b4902d247e4693 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
