Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/2800/2/openbsc/src/libbsc/abis_nm.c
File openbsc/src/libbsc/abis_nm.c:

Line 488:                       LOGP(DNM, LOGL_NOTICE, "Get Attributes 
Response: BTS%u feature vector is truncated to %u bytes\n",
log messages should have formatting as consistent as possible.  Sometimes you 
start with BTS%u, in other cases it's in the middle of the line.  Is that 
really necessary?


-- 
To view, visit https://gerrit.osmocom.org/2800
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic35b2865998bca3c2c0cb4b77e4e73d12e08bd7e
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to