Patch Set 3:

> get_p_max_out_mdBm() should be used in this context, with no fall-back

See updated revision, not sure if I'm doing it right - is there some limit on 
returned value?

> why are we encoding the power in an IE that is called STATE ?!?

Because I was unable to find any other suitable attribute among the 3GPP TS 
52.021 ยง9.4 so I've used manufacturer-depended attribute. Which one would be 
better to use in this case?

> why do we pass attr_out_index+1 into the function

Well, we either pass +1 or return +1 - see updated version.

-- 
To view, visit https://gerrit.osmocom.org/2786
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f72305bbf1ab74745bffac1bee9f539f5a6de32
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <[email protected]>
Gerrit-HasComments: No

Reply via email to